This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 936d299246c2be32cfc92e0ad824f31d5b8cec73
- From: palves at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 20 May 2014 18:17:04 -0000
- Subject: gdb and binutils branch master updated. 936d299246c2be32cfc92e0ad824f31d5b8cec73
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 936d299246c2be32cfc92e0ad824f31d5b8cec73 (commit)
from 9440a9045928d3d4624b8dbcfbd98587a49d35e7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=936d299246c2be32cfc92e0ad824f31d5b8cec73
commit 936d299246c2be32cfc92e0ad824f31d5b8cec73
Author: Pedro Alves <palves@redhat.com>
Date: Tue May 20 19:11:39 2014 +0100
Make compare-sections work against all targets; add compare-sections [-r] tests.
This does two things:
1. Adds a test.
Recently compare-sections got a new "-r" switch, but given no test
existed for compare-sections, the patch was allowed in with no
testsuite addition. This now adds a test for both compare-sections
and compare-sections -r.
2. Makes the compare-sections command work against all targets.
Currently, compare-sections only works with remote targets, and only
those that support the qCRC packet. The patch makes it so that if the
target doesn't support accelerating memory verification, then GDB
falls back to comparing memory itself. This is of course slower, but
it's better than nothing, IMO. While testing against extended-remote
GDBserver I noticed that we send the qCRC request to the target if
we're connected, but not yet running a program. That can't work of
course -- the patch fixes that. This all also goes in the direction
of bridging the local/remote parity gap.
I didn't decouple 1. from 2., because that would mean that the test
would need to handle the case of the target not supporting the
command.
Tested on x86_64 Fedora 17, native, remote GDBserver, and
extended-remote GDBserver. I also hack-disabled qCRC support to make
sure the fallback paths in remote.c work.
gdb/doc/
2014-05-20 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Memory) <compare-sections>: Generalize comments to
not be remote specific. Add cross reference to the qCRC packet.
(Separate Debug Files): Update cross reference to the qCRC packet.
(General Query Packets) <qCRC packet>: Add anchor.
gdb/
2014-05-20 Pedro Alves <palves@redhat.com>
* NEWS: Mention that compare-sections now works with all targets.
* remote.c (PACKET_qCRC): New enum value.
(remote_verify_memory): Don't send qCRC if the target has no
execution. Use packet_support/packet_ok. If the target doesn't
support the qCRC packet, fallback to a deep memory copy.
(compare_sections_command): Say "target image" instead of "remote
executable".
(_initialize_remote): Add PACKET_qCRC to the list of config
packets that have no associated command. Extend comment.
* target.c (simple_verify_memory, default_verify_memory): New
function.
* target.h (struct target_ops) <to_verify_memory>: Default to
default_verify_memory.
(simple_verify_memory): New declaration.
* target-delegates.c: Regenerate.
gdb/testsuite/
2014-05-20 Pedro Alves <palves@redhat.com>
* gdb.base/compare-sections.c: New file.
* gdb.base/compare-sections.exp: New file.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 19 ++++
gdb/NEWS | 3 +
gdb/doc/ChangeLog | 7 ++
gdb/doc/gdb.texinfo | 31 +++---
gdb/remote.c | 52 ++++++----
gdb/target-delegates.c | 8 +--
gdb/target.c | 43 ++++++++
gdb/target.h | 10 ++-
gdb/testsuite/ChangeLog | 5 +
gdb/testsuite/gdb.base/compare-sections.c | 26 +++++
gdb/testsuite/gdb.base/compare-sections.exp | 152 +++++++++++++++++++++++++++
11 files changed, 316 insertions(+), 40 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/compare-sections.c
create mode 100644 gdb/testsuite/gdb.base/compare-sections.exp
hooks/post-receive
--
gdb and binutils