This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog linux-record.c


CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-03-07 18:29:05

Modified files:
	gdb            : ChangeLog linux-record.c 

Log message:
	linux-record.c:record_linux_system_call: fix -Wpointer-sign
	
	$ make WERROR_CFLAGS="-Wpointer-sign -Werror" linux-record.o 2>&1 1>/dev/null
	...
	../../src/gdb/linux-record.c: In function â??record_linux_system_callâ??:
	../../src/gdb/linux-record.c:1152:9: error: pointer targets in passing argument 3 of â??regcache_raw_read_signedâ?? differ in signedness [-Werror=pointer-sign]
	In file included from ../../src/gdb/linux-record.c:23:0:
	../../src/gdb/regcache.h:76:3: note: expected â??long int *â?? but argument is of type â??long unsigned int *â??
	../../src/gdb/linux-record.c:1186:13: error: pointer targets in passing argument 3 of â??regcache_raw_read_signedâ?? differ in signedness [-Werror=pointer-sign]
	In file included from ../../src/gdb/linux-record.c:23:0:
	../../src/gdb/regcache.h:76:3: note: expected â??long int *â?? but argument is of type â??long unsigned int *â??
	
	I believe the read_signed calls are correct, and the variables are in
	the wrong.
	
	Tested on x86_64 Fedora 17.
	
	gdb/
	2013-03-07  Pedro Alves  <palves@redhat.com>
	
	* linux-record.c (record_linux_system_call) <gdb_sys_msgrcv,
	RECORD_MSGRCV>: Pass a signed variable to
	regcache_raw_read_signed, instead of an unsigned one.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15216&r2=1.15217
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/linux-record.c.diff?cvsroot=src&r1=1.16&r2=1.17


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]