This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] libdw: Read DW_AT_decl_file/line/column as unsigned
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 06 Feb 2014 14:02:31 +0100
- Subject: Re: [PATCH] libdw: Read DW_AT_decl_file/line/column as unsigned
On Wed, 2014-02-05 at 11:58 -0800, Josh Stone wrote:
> Section 2.14 of the DWARF v3 & v4 standards specifies that all three
> declaration coordinates are unsigned integer constants. DWARF v2 did
> not specify signedness. Now dwarf_decl_* use dwarf_formudata to read
> these values.
> Also, an assertion on the range of line/column is now a handled error,
> setting DWARF_E_INVALID_DWARF for values greater than INT_MAX.
> Signed-off-by: Josh Stone <firstname.lastname@example.org>
> libdw/ChangeLog | 6 ++++++
> libdw/dwarf_decl_file.c | 4 ++--
> libdw/dwarf_decl_line.c | 13 +++++++++----
> 3 files changed, 17 insertions(+), 6 deletions(-)
Looks good to me.