This is the mail archive of the
mailing list for the elfutils project.
Re: dwarf_aggregate_size() seems to fall over on pointer types
- From: Conrad Rad <cse dot cem at gmail dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 02 Oct 2014 08:50:20 -0400
- Subject: Re: dwarf_aggregate_size() seems to fall over on pointer types
On Thu, Oct 2, 2014 at 8:05 AM, Mark Wielaard <firstname.lastname@example.org> wrote:
> Oops. That shows why I shouldn't submit patches without testcases...
> Thanks for testing and fixing.
> Here is the fixed up patch plus some testcases to show it actually
If you're going to tag me for Tested-by, it's "Conrad Meyer." (Google
just doesn't let me use my real name for email and a pseudonym for all
their other services, so it's a compromise.)
Looks good to me, thanks Mark. Maybe document the architecture the
object files were produced on / the tests are in reference to? The
sizes seem hardcoded for 64-bit pointer / 64-bit long architectures.
Not a big deal.
I don't know the proper way to run elfutils tests, but I gave it a go:
$ export srcdir=`pwd`; ./run-aggregate-size.sh
rmdir: failed to remove ‘test-20508’: Directory not empty
$ echo $?
$ ls test-20508
No other output. I'm probably doing it wrong, but I didn't find any
documentation in the tests/ directory.