This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 5/5] Use seek+read instead of pread to read from /dev/$$/mem files.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 09 Oct 2015 15:44:52 +0200
- Subject: Re: [PATCH 5/5] Use seek+read instead of pread to read from /dev/$$/mem files.
On Fri, 2015-10-09 at 12:35 +0200, Jose E. Marchesi wrote:
> Here you go.
>
> commit 43f68c295e60ca716bc5d1a3876c62f949d4f889
> Author: Jose E. Marchesi <jose.marchesi@oracle.com>
> Date: Fri Oct 9 06:38:39 2015 -0400
>
> Use seek+read instead of pread to read from /dev/$$/mem files.
>
> pread[64] always returns EINVAL when negative offsets are used.
> read+seek allows us to read in-memory vdso objects mapped high in the
> address space.
>
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Looks good. Thanks. Pushed to master.