This is the mail archive of the mailing list for the elfutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libdwfl: Record dwfl_attach_state error and return it on failure.

On Wed, 11 Jun 2014 15:33:28 +0200, Mark Wielaard wrote:
> When dwfl_attach_state fails functions that need the process state should
> return the error that caused the attach to fail. Use this in the backtrace
> test to signal any attach failure. This makes sure that architectures that
> don't provide unwinder support get properly detected (and the tests SKIPs)
> Also don't assert when trying to attach a non-core ELF file, but return an
> error to indicate failure.

This patch reimplements former 'process_attach_error' under the new name
'attacherr'.  It is also related to the current requirement to call
dwfl_linux_proc_attach() explicitly by the clients since:
	commit 19108019192ab273c53ae324be448d29dac806ca
	Author: Mark Wielaard <>
	Date:   Mon Dec 30 22:00:57 2013 +0100
	    libdwfl: Add dwfl_core_file_attach and dwfl_linux_proc_attach.
So I rather do not agree with the former patch which this one fixes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]