This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] stack: Add --quiet to not resolve addresses, add --raw to not demangle.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 02 Jan 2014 21:31:14 +0100
- Subject: Re: [PATCH] stack: Add --quiet to not resolve addresses, add --raw to not demangle.
On Mon, 23 Dec 2013 21:35:41 +0100, Mark Wielaard wrote:
> +#ifdef USE_DEMANGLE
> + case 'r':
> + show_raw = true;
> + break;
It is more a nitpick but I do not find too great that a build without
demangling support will fail "eu-stack -r ..." with:
eu-stack: invalid option -- 'r'
Try `stack --help' or `stack --usage' for more information.
Despite it could display the information requested.
-r should be IMO just ignored for builds without demangling support.
The demangling would be just a best-effort. After all a mangled symbol name
is still a valid symbol name.
The current USE_DEMANGLE #ifdefs in elfutils are in src/nm.C where it is used
in opposite way - to explicitly enable demangling with -C. There it makes
sense to fail if -C was explicitly requested and the build cannot provide it.