This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 2/3] libdw: optimize dwarf_hasattr to just look@abbrev
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 11 Dec 2014 12:34:45 +0100
- Subject: Re: [PATCH 2/3] libdw: optimize dwarf_hasattr to just look@abbrev
On Wed, 2014-12-10 at 18:48 -0800, Josh Stone wrote:
> To just check the presence of an attribute, we only need to look at the
> abbreviation data. This optimization avoids reading over die data at all,
> except possibly just to get the abbrev code.
> 2014-12-10 Josh Stone <firstname.lastname@example.org>
> + * dwarf_hasattr.c (dwarf_hasattr): Just walk abbrev for presence.
Sorry for the irritating nitpick, but there is a missing blank line
after the date line in the ChangeLog entry.
Looks nice. Good find!