This is the mail archive of the mailing list for the elfutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix check for strippable relocation section.

On 10 Oct 2012, Mark Wielaard uttered the following:

> On Tue, 2012-09-18 at 20:23 +0100, Nick Alcock wrote:
>> When deciding whether a section is strippable, ebl_section_strip_p()
>> checks the section pointed to by the sh_info of relocation sections
>> to see if the relocated section is strippable.
>> Unfortunately a one-character typo leads to this check always being
>> skipped.  (You can tell it's a typo because if the condition were
>> correct, the next line would dereference a null pointer.)
>> Signed-off-by: Nick Alcock <>
> Things should have been setup so that you can push this yourself.
> But I can also do it for you.

Hold off: work said yes about the contributor agreement and then as soon
as I'd agreed to it, said 'no, wait for legal'. I'm now acting as if I
hadn't agreed to it, and waiting for legal. For weeks and weeks. Even
though dozens of people in my department have already signed it. Sigh.

Sorry about this :( I'll rebase against trunk and repost once I'm
actually allowed to push this exciting one-character change.

NULL && (void)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]