This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: pmachata/reader_hooks branch
- From: Ulrich Drepper <drepper at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 29 May 2009 13:32:25 -0700
- Subject: Re: pmachata/reader_hooks branch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Roland McGrath wrote:
> Please review "git diff origin/master..origin/pmachata/reader_hooks".
> If you like it fine, we'll merge the branch into master.
What's the performance impact? How will it be when the more
sophisticated reader hooks are used? There are an awful lot of nested
function calls. Although they are marked inline, are we sure gcc sees
through that?
Details: don't define more than one variable per line. E.g.,
+ unsigned char *readp, *readendp;
Aside from that it looks OK.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkogRlgACgkQ2ijCOnn/RHS4hACguTlQIpL6jVNzj4oKVHlknF0t
QBQAnRkXDJnHZxRjIEgSCMKzjsw4vGKT
=LUmP
-----END PGP SIGNATURE-----