This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 1/3] Add an inlined fast path for __libdw_form_val_len
- From: Josh Stone <jistone at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 16 Dec 2013 14:30:29 -0800
- Subject: Re: [PATCH 1/3] Add an inlined fast path for __libdw_form_val_len
On 12/16/2013 02:18 PM, Roland McGrath wrote:
>> + /* Note that form_lengths[flag_present] is 0, like every other absent index.
>> + * But since flag_present's length truly is 0, check for it explicitly. */
> Extra * is bad comment formatting.
Right, Petr caught that on v2. These are committed now, but of course
I'll still go back and address concerns if needed...