This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: supporting DW_OP_{implicit,stack}_value


On Wed, 2009-07-22 at 13:12 -0700, Roland McGrath wrote:
> I like "ou of band" for this case.  I just wanted "in-band" for the
> DW_CFA_val_* cases using the DW_OP_stack_value suffix, and some way
> to keep the API fairly simple.  So you suggest:
> 
> 	return 0, *ops = ops_mem -> "undefined"
> 	return 0, *ops = NULL	 -> "same_value"
> 
> ?

Yep. Although I would be fine with any *ops != NULL.
I admit to not be completely clear on why the caller is providing the
ops_mem array (or why it increased from 2 to 3 in this proposal). If it
is an optimization for memory use, could you let the user provide an
arbitrary length array (and reuse *nops also as input size)?

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]