This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] libdw: Simplify __libdw_visit_scopes' tag checks
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 25 Sep 2013 12:52:25 +0200
- Subject: Re: [PATCH] libdw: Simplify __libdw_visit_scopes' tag checks
On Tue, 2013-09-24 at 16:04 -0700, Josh Stone wrote:
> The former classify_die() was splitting tags into more classes than
> actually needed.
> The one place that used the "imported" die_class now just compares to
> DW_TAG_imported_unit directly.
> The recursion check was squashing "match", "match_inline", and "walk"
> into the same action. Now that uses the new may_have_scopes(), which
> just returns true for all tags that had those classifications.
> The net result has no functional change, but performs better.
> Signed-off-by: Josh Stone <firstname.lastname@example.org>
Looks good to me. Thanks.
I can push it for you, or you can request committer status here: