This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] libdw: Add dwarf_peel_type. Use it in dwarf_aggregate_size.
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 05 Nov 2014 17:02:30 +0100
- Subject: Re: [PATCH] libdw: Add dwarf_peel_type. Use it in dwarf_aggregate_size.
Mark Wielaard <firstname.lastname@example.org> writes:
> Is it clear what the intent of the function is?
> And when we do extend the tags that get peeled, do we need to update
> the function symbol version?
I don't think so. If we are adding new tags (i.e. from a new Dwarf
version) and the additions fit into existing contract, then callers
should benefit from the improvements without having to be rebuilt.
Adding more tags from existing versions is something of a gray area, as
the code could easily assume a set of tags that are peeled. I still
lean towards not bumping. If the contract didn't change, this is just
bugfixing. We really should have peeled this particular tag, as it fits
the bill, but we forgot about it.