This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 2/3] Simplify and inline get_uleb128 and get_sleb128
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 24 Apr 2014 00:32:48 +0200
- Subject: Re: [PATCH 2/3] Simplify and inline get_uleb128 and get_sleb128
Mark Wielaard <firstname.lastname@example.org> writes:
> On Wed, 2014-04-23 at 22:29 +0200, Petr Machata wrote:
>> How's this for a counter-proposal? I shamelessly reused your commit
>> message and ChangeLog wording, please let me know if that's overstepping
> No it isn't. And thanks for the proposal.
> But I think I prefer the fix using multiplication as posted here:
> That one is also just a oneliner and more generic since it doesn't rely
> on having to cast to uint64_t. And Richard checked it still just
> generates a shift.
Ah, cool, I didn't notice that e-mail.