This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH v2 0/2] Add support for BPF
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 22 Jun 2016 16:54:44 +0200
- Subject: Re: [PATCH v2 0/2] Add support for BPF
On Tue, 2016-06-21 at 15:10 -0700, Richard Henderson wrote:
> Changes since v2:
> (1) We've got an official number for EM_BPF,
> (2) A disassembly test case,
> (3) Added a configure test for <linux/bpf.h>,
> (4) Byte swapping of bpf_insns during disassembly,
> (5) ChangeLog entries.
This all looks very good. Only one small build infrastructure thingy:
diff --git a/backends/Makefile.am b/backends/Makefile.am
> @@ -118,6 +118,11 @@ m68k_SRCS = m68k_init.c m68k_symbol.c m68k_regs.c \
> libebl_m68k_pic_a_SOURCES = $(m68k_SRCS)
> am_libebl_m68k_pic_a_OBJECTS = $(m68k_SRCS:.c=.os)
> +bpf_SRCS = bpf_init.c bpf_regs.c
> +cpu_bpf = ../libcpu/libcpu_bpf.a
> +libebl_bpf_pic_a_SOURCES = $(bpf_SRCS)
> +am_libebl_bpf_pic_a_OBJECTS = $(bpf_SRCS:.c=.os)
Only the disasm hook (which is already guarded) depends on cpu_bpf.
Since that is only build when we have bpf.h this also needs a guard:
cpu_bpf = ../libcpu/libcpu_bpf.a
Lets push this with that small tweak as soon as the glibc elf.h lands.