This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] libdw: Search for the last matching address with dwarf_getsrc_die.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Fri, 16 Jan 2015 09:09:11 +0100
- Subject: Re: [PATCH] libdw: Search for the last matching address with dwarf_getsrc_die.
On Thu, 2015-01-15 at 11:54 -0800, Josh Stone wrote:
> On 01/12/2015 01:25 PM, Mark Wielaard wrote:
> > On Sat, 2014-12-27 at 16:49 +0100, Mark Wielaard wrote:
> >> I think you are right and those tests, addrscopes and funcscopes, are
> >> wrong. They use dwfl_module_getsrc to find the line associated with start
> >> and end of the scope. But for the end they use the value of the high_pc
> >> attribute. The high_pc attributes indicates the first address beyond
> >> the current scope of the associated DIE. So the tests should use
> >> highpc - 1 as end of scope.
> >> I created a patch to change dwfl_module_getsrc to not match against
> >> a line with end_sequence set, changed the tests to use highpc -1.
> >> And adjusted this patch for dwarf_getsrc_die. to match the new
> >> behavior. Do those changes look correct to you?
> > Those are the following 2 commits on the mjw/pending branch:
> Both look good to me.
Thanks for looking over them. I pushed both to master.