Re: [PATCH] libdw: dwarf_getsrclines mark highest address as end_sequence.

[Petr Machata <pmachata at redhat dot com>]

Mark Wielaard <mjw@redhat.com> writes:

> Make sure the highest address for the CU is marked as end_sequence.
> This is required by the DWARF spec, but some compilers forget and
> dwfl_module_getsrc depends on it.  We could reject it as bad DWARF
> but the DWARF .debug_lines spec is much stricter than what compilers
> seem to output in practice.

For context: right now we assert when we encounter Dwarf like that, so
this is certainly better.

I'm kind of split on this, a part of me would like to reject such Dwarf.
But this is more helpful to the user, and even though this could result
in a wrong answer, that's just garbage in-garbage out principle at
works.

Thanks,
PM