This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libdwfl: Fix and test aux_sym address_sync with relocated ELF
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 18 Nov 2013 23:41:33 +0100
- Subject: Re: [PATCH] libdwfl: Fix and test aux_sym address_sync with relocated ELF
On Mon, 2013-11-18 at 14:34 -0800, Josh Stone wrote:
> The aux_sym address_sync already worked with a full prelink, which has
> .gnu.prelink_undo, but it failed on plain relocations with prelink -r.
>
> Now it uses the difference in ehdr.e_entry as a first offset guess, and
> the tests confirm this seems to work fine.
Thanks to Jan Kratochvil for suggesting that trick on irc!
> +2013-11-18 Josh Stone <jistone@redhat.com>
> +
> + * dwfl_module_getdwarf.c (find_aux_address_sync): New function.
> + (find_aux_sym): Use it.
> [...]
> +2013-11-18 Josh Stone <jistone@redhat.com>
> +
> + * testfilebazdbg_plr.bz2: New testfile.
> + * testfilebazmin_plr.bz2: Likewise.
> + * Makefile.am (EXTRA_DIST): Add the above files.
> + * run-dwflsyms.sh: Add prelink -r tests.
Looks good to me. Thanks for the new testcases. Cute sed trick.
Thanks,
Mark