[commit] [patch 2/4] Code cleanup: Remove const in prototype

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Thu, 14 Nov 2013 20:19:32 +0100, Mark Wielaard wrote:
> I think removing the const is harmless like you said.

IIUC it was an approval.


Thanks,
Jan


Code cleanup: Remove const in prototype

Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
---
 libdwfl/ChangeLog          | 8 ++++++++
 libdwfl/dwfl_frame_regs.c  | 2 +-
 libdwfl/libdwfl.h          | 2 +-
 libdwfl/linux-pid-attach.c | 6 ++----
 libebl/ChangeLog           | 5 +++++
 libebl/libebl.h            | 6 ++----
 6 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 561017b..9901380 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,5 +1,13 @@
 2013-11-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
+	Code cleanup: Remove const in prototype
+	* dwfl_frame_regs.c (dwfl_thread_state_registers): Remove const from
+	firstreg.
+	* libdwfl.h (dwfl_thread_state_registers): Likewise.
+	* linux-pid-attach.c (pid_thread_state_registers_cb): Likewise.
+
+2013-11-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
 	Fix dwfl_attach_state machine->elf.
 	* dwfl_frame.c (dwfl_attach_state): Change parameter machine to elf.
 	Call ebl_openbackend instead of ebl_openbackend_machine.
diff --git a/libdwfl/dwfl_frame_regs.c b/libdwfl/dwfl_frame_regs.c
index 927bc15..10803fe 100644
--- a/libdwfl/dwfl_frame_regs.c
+++ b/libdwfl/dwfl_frame_regs.c
@@ -29,7 +29,7 @@
 #include "libdwflP.h"
 
 bool
-dwfl_thread_state_registers (Dwfl_Thread *thread, const int firstreg,
+dwfl_thread_state_registers (Dwfl_Thread *thread, int firstreg,
 			     unsigned nregs, const Dwarf_Word *regs)
 {
   Dwfl_Frame *state = thread->unwound;
diff --git a/libdwfl/libdwfl.h b/libdwfl/libdwfl.h
index 303f79c..c1a0fb9 100644
--- a/libdwfl/libdwfl.h
+++ b/libdwfl/libdwfl.h
@@ -657,7 +657,7 @@ Dwfl_Thread *dwfl_frame_thread (Dwfl_Frame *state)
    For every known continuous block of registers <FIRSTREG..FIRSTREG+NREGS)
    (inclusive..exclusive) set their content to REGS (array of NREGS items).
    Function returns false if any of the registers has invalid number.  */
-bool dwfl_thread_state_registers (Dwfl_Thread *thread, const int firstreg,
+bool dwfl_thread_state_registers (Dwfl_Thread *thread, int firstreg,
                                   unsigned nregs, const Dwarf_Word *regs)
   __nonnull_attribute__ (1, 4);
 
diff --git a/libdwfl/linux-pid-attach.c b/libdwfl/linux-pid-attach.c
index b4f3165..ca82144 100644
--- a/libdwfl/linux-pid-attach.c
+++ b/libdwfl/linux-pid-attach.c
@@ -198,10 +198,8 @@ pid_next_thread (Dwfl *dwfl __attribute__ ((unused)), void *dwfl_arg,
 /* Implement the ebl_set_initial_registers_tid setfunc callback.  */
 
 static bool
-pid_thread_state_registers_cb (const int firstreg,
-			       unsigned nregs,
-			       const Dwarf_Word *regs,
-			       void *arg)
+pid_thread_state_registers_cb (int firstreg, unsigned nregs,
+			       const Dwarf_Word *regs, void *arg)
 {
   Dwfl_Thread *thread = (Dwfl_Thread *) arg;
   return INTUSE(dwfl_thread_state_registers) (thread, firstreg, nregs, regs);
diff --git a/libebl/ChangeLog b/libebl/ChangeLog
index 57f9f46..eed4481 100644
--- a/libebl/ChangeLog
+++ b/libebl/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Code cleanup: Remove const in prototype
+	* libebl.h (ebl_tid_registers_t): Remove const from firstreg.
+
 2013-11-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
 	    Mark Wielaard  <mjw@redhat.com>
 
diff --git a/libebl/libebl.h b/libebl/libebl.h
index 622f9e8..045a198 100644
--- a/libebl/libebl.h
+++ b/libebl/libebl.h
@@ -384,10 +384,8 @@ extern int ebl_auxv_info (Ebl *ebl, GElf_Xword a_type,
   __nonnull_attribute__ (1, 3, 4);
 
 /* Callback type for ebl_set_initial_registers_tid.  */
-typedef bool (ebl_tid_registers_t) (const int firstreg,
-				    unsigned nregs,
-				    const Dwarf_Word *regs,
-				    void *arg)
+typedef bool (ebl_tid_registers_t) (int firstreg, unsigned nregs,
+				    const Dwarf_Word *regs, void *arg)
   __nonnull_attribute__ (3);
 
 /* Callback to fetch process data from live TID.
-- 
1.8.3.1