This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Strip on mips


> > > 	mips_debugscn_p (const GElf_Shdr *shdr, const char *name)
> > > 	{
> > > 	  if (shdr != NULL && shdr->sh_type == SHT_MIPS_DWARF)
> > > 	    return true;
> > > 	  return (*generic_debugscn_p) (shdr, name);
> > > 	}
> > 
> > Does that mean generic_debugscn shouldn't check the shdr?  Because
> > now it would check it and then fail for mips because it's not
> > SHT_PROGBITS.

The code above never calls generic_debugscn if sh_type is SHT_MIPS_DWARF.
If the type is neither SHT_MIPS_DWARF nor SHT_PROGBITS, I don't know why
we'd want it to return true.  I don't understand what case you are
concerned about.


Thanks,
Roland

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]