This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] Add support for m68k
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 24 May 2016 13:52:42 +0200
- Subject: Re: [PATCH] Add support for m68k
On Mon, 2016-05-23 at 19:01 +0200, Andreas Schwab wrote:
> Mark Wielaard <email@example.com> writes:
> > How does the make check result look on m68k with this patch applied?
> SKIP: run-addr2line-i-demangle-test.sh
> SKIP: run-backtrace-native.sh
> SKIP: run-backtrace-data.sh
> SKIP: run-backtrace-dwarf.sh
> SKIP: run-backtrace-native-biarch.sh
> SKIP: run-backtrace-native-core.sh
> SKIP: run-backtrace-native-core-biarch.sh
> SKIP: run-backtrace-demangle.sh
> SKIP: run-stack-demangled-test.sh
> SKIP: run-deleted.sh
> Testsuite summary for elfutils 0.164
> # TOTAL: 145
> # PASS: 135
> # SKIP: 10
> # XFAIL: 0
> # FAIL: 0
> # XPASS: 0
> # ERROR: 0
Those are great results. That means all native-self tests PASS. And the
SKIPPED (backtrace, stack, deleted) results are expected since the
backend doesn't implement backtrace support.
The run-addr2line-i-demangle-test.sh SKIP is because your setup doesn't
have libstdc++.so with __cxa_demangle installed.
> > Could you provide testcases/files for run-readelf-mixed-corenote.sh,
> > run-allregs.sh, run-strip-test?.sh and/or run-strip-reloc.sh. That way
> > people can run make check on a non-m68k setup and see whether m68k ELF
> > files are handled properly.
> Yes, I can do that.
> > If you are ambitious you could also add support for backtraces by
> > implementing m68k_init_reg.c set_initial_registers_tid, m68k_cfi.c
> > abi_cfi, frame_nregs.
> My first goal was to get a clean testsuite, but I'll continue to work on
> the optional parts.
Thanks. I pushed your current patch as is to master.