This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 5/5] addr2line: Add --pretty-print option to show all information on one line.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 20 May 2015 11:28:40 -0700
- Subject: Re: [PATCH 5/5] addr2line: Add --pretty-print option to show all information on one line.
If we're starting to aim for compatibility with binutils, then perhaps we
should change -p to match. I think having only --pid would be OK.
> + printf ("%s%s", symname (name), pretty ? " " : "\n");
Use %c. Several other instances below.
> + name = (name != NULL) ? symname (name) : "??";
No need for parens.