Re: [PATCH] configure: add a --disable-werror option

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 02 January 2014 16:48:38 Mark Wielaard wrote:
> On Thu, Jan 02, 2014 at 07:44:48AM -0500, Mike Frysinger wrote:
> > no distro ships elfutils w/out the portability/robustify patches
> > applied which means no one in the world is testing the tarballs that
> > the project is releasing.  it's ridiculous that both patches continue
> > to exist as separate branches.
> > 
> > but it seems that i'm the only one of this opinion, so the status quo
> > isn't going to change.
> 
> Actually I agree with at least half of what you are saying. For the next
> release (after 0.158 is out) I'll make an effort to merge the robustify
> patches to mainline. But the portability branch really is only needed
> for ancient toolchains and can contain stuff that is inefficient on a
> modern GNU/Linux setup. It isn't used in fedora >= 9 or rhel >= 6 for
> example.

the majority of those changes are just for old toolchains (looks like gcc-4.3 
is the oldest version that'll work, but that's what we've been requiring in 
glibc for a few releases and no one seems to mind, so shouldn't be an issue).

i think these belong in the main branch though:

35ae9cf964c2de52bb4d03412334fe83338393ee
- adds an abort() after an assert()
if you build with -DNDEBUG, the assert() is a NOP, and the code can continue 
running when it clearly shouldn't.

a3462c319770a035e8a1deed5b49f5a0d95c5a2b
- support systems that lack tls
probably not terribly important as every arch that is supported by current 
glibc has tls support now, but not every C library supports tls.  plus, this 
change has like no overhead for the project (it's a minor tweak to configure.ac 
only).

5f96b96cba442bf0694c08489c3961f95fd69d7e
- add support for --disable-werror (a refreshed version which started this 
thread)
pretty much every other project (GNU or otherwise) which leverages -Werror 
during build has this type of flag.  you can't control the default compile flags 
that users/distros use, and many of those can easily trigger warnings that you 
don't expect (or don't even want to handle because they're largely harmless).  
it also doesn't change the default behavior for anyone.
-mike

Attachment: signature.asc
Description: PGP signature