This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch 1/4] Fix dwfl_attach_state machine->elf
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 14 Nov 2013 16:16:26 +0100
- Subject: Re: [patch 1/4] Fix dwfl_attach_state machine->elf
On Sun, 2013-11-10 at 21:21 +0100, Jan Kratochvil wrote:
> libdwfl/
> 2013-11-10 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix dwfl_attach_state machine->elf.
> * dwfl_frame.c (dwfl_attach_state): Change parameter machine to elf.
> Call ebl_openbackend instead of ebl_openbackend_machine.
> * libdwfl.h (dwfl_attach_state): Change parameter machine to elf.
> Update the function description.
> * linux-core-attach.c (__libdwfl_attach_state_for_core): Pass CORE to
> dwfl_attach_state.
> * linux-pid-attach.c (__libdwfl_attach_state_for_pid): Pass NULL to
> dwfl_attach_state.
Yes, this makes sense to me. The elf is more "natural" to pass around
than the more abstract e_machine. Looks good.
Thanks,
Mark