This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] libdw: Add overflow checking to __libdw_form_val_len.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 11 Dec 2014 15:11:21 +0100
- Subject: Re: [PATCH] libdw: Add overflow checking to __libdw_form_val_len.
On Tue, 2014-12-09 at 18:44 -0800, Josh Stone wrote:
> Ok, well my former optimizations went into 0.158. Here are some quick
> runs of "varlocs -k >/dev/null" on kernel-3.17.4-301.fc21.x86_64:
> 0.157 96.00user 0.12system 1:36.08elapsed
> 0.158 70.22user 0.12system 1:10.32elapsed
> 0.159 71.40user 0.11system 1:11.48elapsed
> 0.160 73.24user 0.12system 1:13.33elapsed
> master 77.65user 0.10system 1:17.72elapsed
> patched 77.87user 0.10system 1:17.93elapsed
> So each release has ceded a bit of performance, but this particular
> patch isn't much of an issue. Correctness trumps performance anyway.
Thanks for all the testing (and for your patches trying to get our
performance back). I have now pushed this overflow checking patch to