This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 1/2] Add is_executable to Dwfl_Module.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 10 Sep 2014 09:21:27 +0200
- Subject: Re: [PATCH 1/2] Add is_executable to Dwfl_Module.
On Tue, 09 Sep 2014 23:55:34 +0200, Roland McGrath wrote:
> > int segment; /* Index of first segment table entry. */
> > bool gc; /* Mark/sweep flag. */
> > + bool is_executable : 1; /* Use Dwfl::executable_for_core? */
> If you're going to use a bitfield, then make every other bool in that
> struct a bitfield too. But it's not usually worthwhile. It's
> premature microoptimization that privileges memory over CPU, which
> might not even be the right tradeoff any more.
I really do not mind, up to the maintainer how it all should be.