This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] configure: add a --disable-werror option
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 02 Jan 2014 12:53:40 +0100
- Subject: Re: [PATCH] configure: add a --disable-werror option
On Thu, Jan 02, 2014 at 06:28:14AM -0500, Mike Frysinger wrote:
> Building with -Werror makes a lot of sense for development, but not a lot
> for distro deployments. Changes in default flag settings, versions of the
> compiler or C library, or 3rd party libraries can easily trigger harmless
> warnings that are a waste of time to track down. Especially when elfutils
> itself enables many extra -W flags. So add a configure flag for distros
> to utilize when building.
Please do report any issues you find with -Werror. We explicitly enable
specific -W flags to catch issues. With a modern GNU toolchain the codebase
really should be warning/error free with the default flags. If not, that is
certainly a bug.
For very old setups there is the portable branch and patch set that does
include a --disable-werror option (which you contributed). But in general
that should not be needed.