This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Test case for handling archives with 64-bit symbol table


Mark Wielaard <mjw@redhat.com> writes:

> On Wed, 2012-08-01 at 21:41 +0200, Petr Machata wrote:
>> +	* test-archive64.sh: New test.
>> +	* archive64.a.bz2: New testfile.
>> +	* Makefile.am (TESTS): Add test-archive64.sh.
>> +	(EXTRA_DIST): Likewise.
>
> test-archive64.sh here should be run-test-archive64.sh.
> And if I may bother you with one other file rename (sorry), could you
> rename archive64.a.bz2 to testarchive64.a.bz2. That would make things a
> bit more consistent in the test directory.
>
> Looks fine otherwise.

I corrected these points and pushed to master.

Thanks,
PM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]