This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch] Implement reglocs for s390/s390x
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 10 Oct 2012 19:45:48 +0200
- Subject: Re: [patch] Implement reglocs for s390/s390x
On Wed, 10 Oct 2012 19:34:38 +0200, Jan Kratochvil wrote:
> * readelf.c (handle_core_items): New variable wrap, choose
> REGISTER_WRAP_COLUMN for "register" group. Use it instead of
> ITEM_WRAP_COLUMN.
[...]
> Initialize COLNO to MAX of also REGISTER_WRAP_COLUMN.
I forgot to explain this part.
The most native display of "upper halves" as items is:
LINUX 64 S390_HIGH_GPRS
high_r0: 1023, high_r1: 1023, high_r2: 0, high_r3: 0, high_r4: 0, high_r5: 1023
high_r6: 0, high_r7: 0, high_r8: 0, high_r9: 0, high_r10: 0, high_r11: 0
high_r12: 1023, high_r13: 0, high_r14: 0, high_r15: 0
But I do not find it much readable. So I chose 'x' format there:
LINUX 64 S390_HIGH_GPRS
high_r0: 0x000003ff, high_r1: 0x000003ff, high_r2: 0x00000000, high_r3: 0x00000000, high_r4: 0x00000000, high_r5: 0x000003ff
high_r6: 0x00000000, high_r7: 0x00000000, high_r8: 0x00000000, high_r9: 0x00000000, high_r10: 0x00000000, high_r11: 0x00000000
high_r12: 0x000003ff, high_r13: 0x00000000, high_r14: 0x00000000, high_r15: 0x00000000
But then it is too wide so I made an exception for the "register" group width:
LINUX 64 S390_HIGH_GPRS
high_r0: 0x000003ff, high_r1: 0x000003ff, high_r2: 0x00000000
high_r3: 0x00000000, high_r4: 0x00000000, high_r5: 0x000003ff
high_r6: 0x00000000, high_r7: 0x00000000, high_r8: 0x00000000
high_r9: 0x00000000, high_r10: 0x00000000, high_r11: 0x00000000
high_r12: 0x000003ff, high_r13: 0x00000000, high_r14: 0x00000000
high_r15: 0x00000000
But in fact I do not mind any format at all.
Thanks,
Jan