This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 1/2] Enable automake parallel-tests for make check.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 25 Apr 2013 14:19:18 -0700
- Subject: Re: [PATCH 1/2] Enable automake parallel-tests for make check.
Looks generally OK. A few potential clean-ups:
I think it will keep everyone saner in the long run if canonical variables
like srcdir have their canonical meanings everywhere. So if you really
need them to use an absolute directory name, then make them use abs_srcdir
as the variable name for that.
Rather than various numbers of ../ prefixes, perhaps it would become easier
to read and to maintain if all those were rewritten in terms of builddir
and/or top_builddir (i.e. $top_builddir/src/readelf, etc.).