This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] config: Fix check for argp_parse to pass &argv
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 02 May 2016 21:51:47 +0200
- Subject: Re: [PATCH] config: Fix check for argp_parse to pass &argv
On Mon, May 02, 2016 at 12:18:47PM -0700, Filipe Brandenburger wrote:
> Right now it's passing a char* when it expects a char** instead.
> This usually produces a warning that may go unnoticed, but if CFLAGS
> contains -Werror, that breaks the ./configure run with the following
> $ ./configure CFLAGS=-Werror
> configure: WARNING: "libc does not have argp"
> checking for argp_parse in -largp... no
> configure: error: "no libargp found"
> Tested: Checked that after this fix, running ./configure CFLAGS=-Werror
> works as expected and argp_parse is correctly detected.
Thanks. Looks correct. I added a ChangeLog entry and pushed this.
(One of these days we'll have to think of an alternative for ChangeLogs.)
Note that in general passing -Werror should not be necessary because
the build should add -Werror where necessary to catch any new warnings
early. Some extra -Werror is always nice of course (although you might
want to watch for where the build uses no_Werror = yes, currently only
ldlex because it is a generated file).