This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] libdwfl: Make dwfl_linux_proc_attach work even without any DwflModules.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 14 Sep 2015 12:47:07 +0200
- Subject: Re: [PATCH] libdwfl: Make dwfl_linux_proc_attach work even without any DwflModules.
On Wed, 2015-09-09 at 12:55 +0200, Mark Wielaard wrote:
> On Tue, 2015-09-08 at 14:53 -0700, Roland McGrath wrote:
> > I think there might be circumstances when you can't open /proc/PID/exe.
> > I'm not sure you want failure to open it or it failing to be a readable
> > ELF file to be hard failures.
>
> I think you are right. Probably not much will actually work
> if /proc/PID/exe cannot be read. But the user might find and report a
> Dwfl_Module that does work for what they need. So I now just silently
> ignore when /proc/PID/exe cannot be read and we fall back to the
> existing mechanism of using one of the existing Dwfl_Modules (we might
> then still fail of course because there is no Dwfl_Module available).
I pushed this variant to master now.
Cheers,
Mark