This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] gelf_getauxv: Use memcpy instead of pointer dereference to avoid alignment problems.
- From: Kurt Roeckx <kurt at roeckx dot be>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Sun, 25 Aug 2013 23:08:36 +0200
- Subject: Re: [PATCH] gelf_getauxv: Use memcpy instead of pointer dereference to avoid alignment problems.
On Sun, Aug 25, 2013 at 11:05:14PM +0200, Mark Wielaard wrote:
> On Sun, Aug 25, 2013 at 09:40:49PM +0200, Kurt Roeckx wrote:
> > It should probably be:
> > memcpy(dst, (char *)data_scn->d.d_buf + ndx * sizeof(GElf_auxv_t), sizeof(GElf_axuv_t));
> I do think so yes.
> On which architecture did you see the alignment problem?
> Is it easily repeatable?
This is the problem I see on sparc.
> BTW. Could you read the CONTRIBUTING file and add a Signed-off-by line
> if possible to your patch.
I forgot about that. Will send new patch shortly.