This is the mail archive of the
mailing list for the elfutils project.
Re: [rfc] Code cleanup: Permit BIAS to be NULL
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 09 Oct 2012 16:51:06 -0700
- Subject: Re: [rfc] Code cleanup: Permit BIAS to be NULL
I think the reason I made them non-optional is that it's such an easy bug
to write code that ignores the bias when it shouldn't. Often you'll have
to have some complex situation involving separate debuginfo and prelink to
actually notice such a bug, so it's doubly easy to leave such bugs around.
I think I'm still convinced by that logic for the public API. For internal
functions where it simplifies the code and we can be fairly confident we
are considering all the strange cases properly (and ideally testing them
all in the test suite), I wouldn't mind it.