This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 16 Aug 2012 14:38:29 -0700
- Subject: Re: [PATCH 3/5] tests: Add run-readelf-unknown-self.sh test to check for unknown DWARF codes.
This doesn't depend on libdw changes, so I would put it as 2/5.
> +# Make sure there are no unknown DWARF codes.
> +testrun_on_self_nomatch "\?\?\?\ \([x0-9]+\)|lo_user\+0x[0-9a-f]+" ../src/readelf -N -w
There's no need for \ before a space. Use single-quotes anywhere you
don't have a reason to use double-quotes in a shell script. It's
especially unclear when using backslashes inside double-quotes, where
some will get stripped and others won't.
Frankly I still think I'd prefer the output be just "%#x" rather than
> + if test $grep_ok == 0; then
Single = in test.
> + exit_status=1;