This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH 1/3] libdw: unify die->abbrev lookups
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 11 Dec 2014 12:25:10 +0100
- Subject: Re: [PATCH 1/3] libdw: unify die->abbrev lookups
On Wed, 2014-12-10 at 18:48 -0800, Josh Stone wrote:
> Add a new internal function, __libdw_dieabbrev, which deals with checking
> a die for an abbrev, and setting it as needed.
> +2014-12-10 Josh Stone <firstname.lastname@example.org>
> + * libdwP.h (__libdw_dieabbrev): New die->abbrev lookup function.
> + * dwarf_child.c (__libdw_find_attr, dwarf_child): Use it.
> + * dwarf_getattrs.c (dwarf_getattrs): Likewise.
> + * dwarf_haschildren.c (dwarf_haschildren): Likewise.
> + * dwarf_tag.c (dwarf_tag): Likewise.
> +/* Get abbreviation of given DIE. */
> +static inline Dwarf_Abbrev *
> +__nonnull_attribute__ (1)
> +__libdw_dieabbrev (Dwarf_Die *die, const unsigned char **readp)
Looks good. But please add a doc comment for the READP argument before
pushing this commit.