This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Let libelf.h's loff_t fall back to off_t


> However, I'm afraid to change signedness, if only because -1 is used in
> error conditions, e.g. returned from elf_update().  Someone checking <0
> will be in for a bad time.

Yeah, that sounds like a wise fear.  But maybe Elf64_Off is OK (and
preferable even) for the cases that are not return values?

> How about just int64_t?  We already pull stdint.h for elf.h, so it seems
> fine to include and use that in libelf.h too.

Sold!  We already have <sys/types.h> which covers <stdint.h> too.  But we
only ever had that for off_t/loff_t, so just change it to <stdint.h> and
use int64_t.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]