This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] aarch64: use <sys/user.h> defined register structures
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 10 Jun 2014 11:51:48 +0200
- Subject: Re: [PATCH] aarch64: use <sys/user.h> defined register structures
On Mon, 2014-06-09 at 21:06 +0200, Kyle McMartin wrote:
> glibc now supplies these (compatible) structs instead of including the
> kernel's <asm/ptrace.h> header, so let's use them. Annoyingly this will
> cause new elfutils to FTBFS on old glibc, and vice versa, but that seems
> unavoidable in the growth of a new port, and the workaround of checking
> for header defines and defining one to the other seems unpleasant as
> well. Therefore, bite the bullet, and let packaging systems alter their
> build requires accordingly.
That is indeed annoying, but using the glibc defined structs seems to be
the right thing to do. Do you know which glibc version introduced them?
BTW. For this trivial patch it doesn't really matter, but in general we
like to have a Signed-off-by line for all patches to indicate
contributors know about and agree with our CONTRIBUTING guidelines.
Would you mind adding one?
https://git.fedorahosted.org/cgit/elfutils.git/tree/CONTRIBUTING
Thanks,
Mark