This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pmachata/reader_hooks review

>> Doing the above, I found myself looking at dwarf_getmacros.  The way 
>> offsets are handled in this functions strikes me as wrong: macoff is 
>> read from attribute, and then never used; [...]
> 
> Yes, it's wrong.  It was never noticed since this was so little used or
> tested, and it always happens to work for the first CU in the section so
> that trivial test cases don't hit the bug.  A test case and fix for that
> for the trunk would be good.

pmachata/pending has a fix and a test case.  Please review.

PM

Attachment: signature.asc
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]