This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: <dwarf>: iteration over attributes swallows the last one


Roland McGrath wrote:
>> As a fix for that, I propose to consider also NULL-ness of _m_attr.value 
>> when doing the iterator comparison.  
> 
> I think you can just do valp == valp comparison and drop the offset
> comparison.  The pointers will match when the offsets match, and two NULLs
> are two end iterators.
> 
> Can you also please write a test case for this?  I'd guess a trivial program
> using .to_string () does it since the busted iterator is used by that.

The changes that you requested, and the testcase, are on pmachata/dwarf.

PM

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]