Re: [PATCH] Move nested functions in gzip.c to file scope.

[Chih-Hung Hsieh <chh at google dot com>]

Sorry about that.
Could you take a look of the new attached 0002*gzip.c*patch?

Thanks.


On Tue, Nov 3, 2015 at 6:05 AM, Mark Wielaard <mjw@redhat.com> wrote:

> On Wed, 2015-10-21 at 14:23 -0700, Chih-Hung Hsieh wrote:
> > * libdwfl/gzip.c should now compile with clang.
> >   All local variables used by nested functions are
> >   passed in an unzip_state structure.
>
> This doesn't build for me. The problem is that this file is supposed to
> build with gzip, bzip2 and/or lzma support. See libdwfl/bzip2.c and
> libdwfl/lzma.c. Which set either LZMA or BZLIB. And gzip.c then uses
> that define to various helper macros to have to decompression functions
> work with any of the gzip, bzip2 or lzma algorithms/libraries. See
> libdwfl/Makefile.am, they are all optional (except gzip in current
> trunk/master). So you will only see this if you configure with bzip2
> and/or lzma support. Make sure that configure says:
>
>   RECOMMENDED FEATURES (should all be yes)
>     gzip support                       : yes
>     bzip2 support                      : yes
>     lzma/xz support                    : yes
>
> Thanks,
>
> Mark
>

Sorry about that.

Could you take a look of the new attached 0002*gzip.c*patch?

Thanks.

On Tue, Nov 3, 2015 at 6:05 AM, Mark Wielaard <mjw@redhat.com> wrote:

On Wed, 2015-10-21 at 14:23 -0700, Chih-Hung Hsieh wrote:
> * libdwfl/gzip.c should now compile with clang.
>   All local variables used by nested functions are
>   passed in an unzip_state structure.

This doesn't build for me. The problem is that this file is supposed to
build with gzip, bzip2 and/or lzma support. See libdwfl/bzip2.c and
libdwfl/lzma.c. Which set either LZMA or BZLIB. And gzip.c then uses
that define to various helper macros to have to decompression functions
work with any of the gzip, bzip2 or lzma algorithms/libraries. See
libdwfl/Makefile.am, they are all optional (except gzip in current
trunk/master). So you will only see this if you configure with bzip2
and/or lzma support. Make sure that configure says:

  RECOMMENDED FEATURES (should all be yes)
    gzip support                       : yes
    bzip2 support                      : yes
    lzma/xz support                    : yes

Thanks,

Mark

Attachment: 0002-Move-nested-functions-in-gzip.c-to-file-scope.patch
Description: Binary data