This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH v3 3/6] libdwelf: Add dwelf_dwarf_gnu_debugaltlink
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 24 Apr 2014 14:53:47 +0200
- Subject: Re: [PATCH v3 3/6] libdwelf: Add dwelf_dwarf_gnu_debugaltlink
On Thu, 2014-04-24 at 14:23 +0200, Florian Weimer wrote:
> On 04/23/2014 02:44 PM, Mark Wielaard wrote:
> >> I'm not sure if this addresses this completely addresses the issue. A
> >> return value of 0 could mean "no debugaltlink data" or "the build ID has
> >> zero length".
> > But a zero length build ID isn't valid, so then you would just return -1
> > and set DWARF_E_INVALID_ELF.
> Okay, I did this in the attached patches.
Thanks. I added them both to the mjw/dwelf branch.
> Do you want me to resubmit the final part concerning libdwfl?
No, thanks. I am experimenting with that patch and changed it to use the
Dwfl find_debuginfo callback to locate the altlink file so that the user
can override the search strategy (and put all resources in the Dwfl so
the free_alt flag in libdw is unnecessary).
I'll post the modified patch when I get it working properly and have it
rebased against your work again.