This is the mail archive of the mailing list for the elfutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] communicate instruction type to disasm callback

On Thu, 2014-12-18 at 12:43 -0500, Ulrich Drepper wrote:
> Similar to what the BFD interface does, these changes introduce a way to
> pass additional information to the callback function provided in the
> disasm_cb call.
> This is an ABI break but I'm pretty sure that I am the only person who
> ever used the interface and the only public user is objdump which is
> also changed.  There is no user, yet, but this information is clearly
> needed for some use cases.
> If someone disagrees I have no problem with bumping the SONAME of
> libasm.

Maybe it would be cleaner to bump the SONAME. Although I think you are
right that there are no real users. [dis]asm_begin () take an Ebl *
argument. Which cannot be gotten through any of the public interfaces.

> Someone please commit the change.

I will, after the 0.161 release (tomorrow). But could you use git -s to
add a Signed-off-by: line as described in the CONTRIBUTING file.
And feel free to just include the ChangeLog entries directly if that is
more convenient for you.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]