This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libebl: Add ebl_unwind_ret_mask.


On Sun, 2014-06-15 at 20:18 +0200, Kurt Roeckx wrote:
> On Sun, Jun 15, 2014 at 12:30:02PM +0200, Mark Wielaard wrote:
> > +  /* Mask to use to get the return address from an unwind in case the
> > +     architecture adds some extra non-address bits to it.  When not
> > +     initialized (0) then ebl_unwind_ret_mask will return ~0, otherwise
> > +     it should be the actual mask to use.  */
> > +  GElf_Addr unwind_ret_mask;
> 
> Shouldn't that be an Elf64_Addr?

No. None of the unwinder uses Elf32 or Elf64 specific types. GElf_Addr
is used here so the unwinder code doesn't need to care about 32-vs-64
issues.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]