This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch] Resolve ppc64 func descriptors as .func (via .opd)
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 05 Dec 2012 15:56:07 +0100
- Subject: Re: [patch] Resolve ppc64 func descriptors as .func (via .opd)
On Wed, 05 Dec 2012 15:35:55 +0100, Mark Wielaard wrote:
> If we could keep the symbol values, except the adjusted st_value intact
> that would have my preference.
Yes, it is this way.
> If you adjust shndxp, do you also adjust sym.st_shndx?
No, I do not. One cannot always set the real value there, it could belong to
SHN_XINDEX.
I can force there SHN_XINDEX during the .opd -> .text rewrite so that no one
mistakenly reads it.
> Both :)
Please do not mix those two.
> The symbol name against which we are matching is what it is, we
> shouldn't change its name IMHO.
We already change st_value and st_shndx. Why not to change also the name?
(Highlighting here the principle a part of the symbol is already changing.
Thanks,
Jan