This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Handle GNU extension opcodes in dwarf_getlocation
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 09 Oct 2012 20:37:36 +0200
- Subject: Re: [PATCH] Handle GNU extension opcodes in dwarf_getlocation
On Tue, Oct 09, 2012 at 02:27:51AM +0200, Petr Machata wrote:
> This is just for low-level byte munching support, so that libdw knows
> how to decode the opcode stream, and doesn't fail when it encounters one
> of the new opcodes.
The decoding of the OPs seems correct. Do you happen to know where
DW_OP_GNU_reinterpret is described, I assumed it was part of
http://www.dwarfstd.org/doc/040408.1.html but it isn't in there.
But it seems correct and like how it is done in readelf.c.
For DW_OP_GNU_entry_value and DW_OP_GNU_const_type we shouldn't
forget to cache the block like we do for implicit_value and provide
a public accessor function (in a later patch).
Cheers,
Mark