This is the mail archive of the
mailing list for the elfutils project.
Re: [PATCH] stack: Improve error checking and exit code handling.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 02 Jan 2014 21:54:04 +0100
- Subject: Re: [PATCH] stack: Improve error checking and exit code handling.
On Fri, 27 Dec 2013 22:37:52 +0100, Mark Wielaard wrote:
> Check up front whether we attached correctly, if not error out. Make sure
> callbacks report -1 only on real errors and DWARF_CB_ABORT if exiting early
> (but not in error). Handle all errors from frame callback in print_frames
> after printing of good frames. Print as much information as possible like
> tid, address and module name if known with error messages. Only exit with
> exit code zero if everything went fine. Exit with error code one if there
> were any non-fatal errors. Exit with error code two if no frames could be
> printed or a fatal error occurred.
OK, thanks, nice fix up.