Re: [PATCH] stack: Add --quiet to not resolve addresses, add --raw to not demangle.

[Mark Wielaard <mjw at redhat dot com>]

On Thu, Jan 02, 2014 at 09:31:14PM +0100, Jan Kratochvil wrote:
> On Mon, 23 Dec 2013 21:35:41 +0100, Mark Wielaard wrote:
> > +#ifdef USE_DEMANGLE
> > +    case 'r':
> > +      show_raw = true;
> > +      break;
> > +#endif
> 
> It is more a nitpick but I do not find too great that a build without
> demangling support will fail "eu-stack -r ..." with:
> 	eu-stack: invalid option -- 'r'
> 	Try `stack --help' or `stack --usage' for more information.
> 
> Despite it could display the information requested.
> 
> -r should be IMO just ignored for builds without demangling support.
> The demangling would be just a best-effort.  After all a mangled symbol name
> is still a valid symbol name.

Yes, that makes sense.

Thanks,

Mark

Attachment: 0001-stack-Show-and-handle-r-raw-even-without-USE_DEMANGL.patch
Description: Text document