This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Move nested functions in gzip.c to file scope.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 03 Nov 2015 15:05:23 +0100
- Subject: Re: [PATCH] Move nested functions in gzip.c to file scope.
On Wed, 2015-10-21 at 14:23 -0700, Chih-Hung Hsieh wrote:
> * libdwfl/gzip.c should now compile with clang.
> All local variables used by nested functions are
> passed in an unzip_state structure.
This doesn't build for me. The problem is that this file is supposed to
build with gzip, bzip2 and/or lzma support. See libdwfl/bzip2.c and
libdwfl/lzma.c. Which set either LZMA or BZLIB. And gzip.c then uses
that define to various helper macros to have to decompression functions
work with any of the gzip, bzip2 or lzma algorithms/libraries. See
libdwfl/Makefile.am, they are all optional (except gzip in current
trunk/master). So you will only see this if you configure with bzip2
and/or lzma support. Make sure that configure says:
RECOMMENDED FEATURES (should all be yes)
gzip support : yes
bzip2 support : yes
lzma/xz support : yes
Thanks,
Mark